Fixing a URL bug in Brave

-
So this week I was working on the Brave browser issue that was filed by our professor.

The issue was based on retrieving a file path from the URL input from the user. In order to replicate the error a user has to create a file path in their local machine and try to access it using the browser URL.

So I had a file named dogcat.txt located in my desktop that just contained the phrase "hello" in it.

So if you try this is chrome you get the content of the file on the browser.
The file displayed on chrome
As you can see the URL contains the path of the file name does not need to be URL space encoded. (dog%20cat.txt)

But if you try to enter the same file path on the brave URL you get a message saying the path doesn't exist.


Now looking at the source code I saw that most of the url based code was contained in a  'urlutil.js' file that exists in 'js/lib'  subdirectory.


Now there are many ways to make this issue work so I went with a very basic approach , that is to make the file path URL encoded.

So basically I took the file path the user passed as a string and replace whitespace with a '%20'.





This way the file path was shown by the browser.

To add a test I wrote a module in the 'urlutilTest.js' file that tests for URL encoding in file names.



Here is a sample of the results.

Comments

Post a Comment

Popular posts from this blog

Fixing issues in debugger.html.

-
Image
In this post I will talk about my experience that went into debugging , compiling and  fixing issues for the  debugger.html  project. The issue I worked on was mostly on the front- end part of the application. The issues that I worked on is listed here . First Issue Second Issue So building and compiling the project is pretty easy (at least on a mac). If you follow the following steps you can get the project up and running. My first issue got accepted and got merged in a recent commit which is always exciting.
Read more

First Open Source Contribution - debugger.html

-
Image
What is the project about? debugger.html is a port of the Mozilla debugger tool that comes with Firefoxes developer tool. It is designed to work on any web browser .This project was built from ground up using React and Redux. debugger.html This is the project running locally on my system. Where is the code located? Most of the source code for the project is located in the src directory.Since it is a React based application most of the "components" is located in the src/components and most of the logic or data driven functions are located in the src/reducers folder. Project structure of debugger.html The components folder contains most of the front end elements of the debugger.Modules such as Editor,Primary Pane , Secondary Panes , Shortcuts are located in this location. The reducers folder contains most of the application state logic. Functionalities such as breakpoints, pauses, event listeners etc lies in this folder. Where are the docs? Most of the
Read more